Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add arabic processors and configs #81

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

add arabic processors and configs #81

wants to merge 29 commits into from

Conversation

lilithgrigoryan
Copy link
Collaborator

@lilithgrigoryan lilithgrigoryan commented Aug 25, 2024

This PR introduces the following:

  1. A processor and config file for the Massive Arabic Speech Corpus (MASC), MCV, Flaurs Arabic, MediaSpeech Arabic, EveryAyah with tests.
  2. A processor to split manifest files by caption file segments.
  3. A processor to aggregate segments into longer ones.
  4. A processor to apply regular expressions to caption files.
  5. A processor for Arabic speech processing.

Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
Copy link
Collaborator

@erastorgueva-nv erastorgueva-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Some small comments to address

dataset_configs/arabic/mcv/config.yaml Outdated Show resolved Hide resolved
sdp/processors/datasets/masc/aggregate_segments.py Outdated Show resolved Hide resolved
sdp/processors/langs/arabic.py Outdated Show resolved Hide resolved
tests/prepare_test_data/prepare_masc_data.py Outdated Show resolved Hide resolved
sdp/processors/datasets/masc/aggregate_segments.py Outdated Show resolved Hide resolved
sdp/processors/datasets/masc/aggregate_segments.py Outdated Show resolved Hide resolved
sdp/processors/datasets/masc/aggregate_segments.py Outdated Show resolved Hide resolved
Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
Copy link
Collaborator

@karpnv karpnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add

# Copyright (c) 2024, NVIDIA CORPORATION.  All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

@karpnv
Copy link
Collaborator

karpnv commented Dec 25, 2024

let's add readme.md to dataset_configs/arabic to refer to it from the paper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants