Conformer-based spectrogram estimator #12002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
anteju
force-pushed
the
pr/se-conformer
branch
from
a484995 to
ef34d1d
Compare
nasretdinovr
reviewed
Feb 4, 2025
|
Tested it locally. Looks good to me |
anteju
force-pushed
the
pr/se-conformer
branch
2 times, most recently
from
10236dc to
d6d0d4e
Compare
nasretdinovr
approved these changes
Feb 5, 2025
Signed-off-by: Ante Jukić <[email protected]>
anteju
force-pushed
the
pr/se-conformer
branch
from
d6d0d4e to
08fc2be
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12002 +/- ##
==========================================
+ Coverage 30.30% 30.41% +0.11%
==========================================
Files 1387 1396 +9
Lines 176283 177115 +832
Branches 27091 27152 +61
==========================================
+ Hits 53423 53876 +453
- Misses 118776 119150 +374
- Partials 4084 4089 +5 ☔ View full report in Codecov by Sentry. |
BoxiangW
pushed a commit
that referenced
this pull request
Feb 7, 2025
Signed-off-by: Ante Jukić <[email protected]>
youngeunkwon0405
pushed a commit
to youngeunkwon0405/NeMo
that referenced
this pull request
Feb 10, 2025
Signed-off-by: Ante Jukić <[email protected]> Signed-off-by: Youngeun Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR adds a spectrogram estimator based on the Conformer architecture.
Collection: audio
Changelog
SpectrogramConformerUsage
N/A
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information