Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flux recipe for ci #12037

Open
wants to merge 106 commits into
base: main
Choose a base branch
from
Open

Add flux recipe for ci #12037

wants to merge 106 commits into from

Conversation

yaoyu-33
Copy link
Collaborator

@yaoyu-33 yaoyu-33 commented Feb 4, 2025

What does this PR do ?

Add flux recipe for ci

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Victor49152 and others added 30 commits September 4, 2024 15:25
Signed-off-by: mingyuanm <[email protected]>
Signed-off-by: mingyuanm <[email protected]>
Signed-off-by: mingyuanm <[email protected]>
…anm/diffusion

# Conflicts:
#	nemo/collections/diffusion/flux/pipeline.py
# Conflicts:
#	nemo/collections/diffusion/__init__.py
#	nemo/collections/diffusion/vae/__init__.py
Signed-off-by: mingyuanm <[email protected]>
Signed-off-by: mingyuanm <[email protected]>
Signed-off-by: mingyuanm <[email protected]>
Signed-off-by: mingyuanm <[email protected]>
Victor49152 and others added 16 commits January 15, 2025 12:02
Signed-off-by: mingyuanm <[email protected]>
…_dict

# Conflicts:
#	nemo/collections/diffusion/data/diffusion_mock_datamodule.py
#	nemo/collections/diffusion/models/flux/model.py
#	nemo/collections/llm/peft/api.py
#	nemo/lightning/_strategy_lib.py
#	nemo/lightning/megatron_parallel.py
#	scripts/dit/dit_train.py
#	scripts/flux/flux_controlnet_infer.py
#	scripts/flux/flux_controlnet_training.py
#	scripts/flux/flux_infer.py
#	scripts/flux/flux_training.py
Signed-off-by: mingyuanm <[email protected]>
Signed-off-by: mingyuanm <[email protected]>
Signed-off-by: mingyuanm <[email protected]>
Signed-off-by: mingyuanm <[email protected]>
Signed-off-by: yaoyu-33 <[email protected]>
Signed-off-by: yaoyu-33 <[email protected]>
Signed-off-by: yaoyu-33 <[email protected]>
yaoyu-33 and others added 3 commits February 4, 2025 13:18
abhinavg4
abhinavg4 previously approved these changes Feb 4, 2025
Copy link
Collaborator

@abhinavg4 abhinavg4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good

Signed-off-by: Yu Yao <[email protected]>
Copy link
Collaborator

@abhinavg4 abhinavg4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.47%. Comparing base (09186c3) to head (17b8d65).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12037      +/-   ##
==========================================
+ Coverage   30.30%   30.47%   +0.17%     
==========================================
  Files        1387     1397      +10     
  Lines      176283   177064     +781     
  Branches    27091    27142      +51     
==========================================
+ Hits        53423    53963     +540     
- Misses     118776   118991     +215     
- Partials     4084     4110      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 6, 2025

[🤖]: Hi @yaoyu-33 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

Copy link
Contributor

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Feb 21, 2025
@yaoyu-33 yaoyu-33 removed the stale label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants