-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flux recipe for ci #12037
base: main
Are you sure you want to change the base?
Add flux recipe for ci #12037
Conversation
Signed-off-by: mingyuanm <[email protected]>
Signed-off-by: mingyuanm <[email protected]>
Signed-off-by: mingyuanm <[email protected]>
Signed-off-by: mingyuanm <[email protected]>
Signed-off-by: mingyuanm <[email protected]>
Signed-off-by: mingyuanm <[email protected]>
Signed-off-by: mingyuanm <[email protected]>
…oising loop. Signed-off-by: mingyuanm <[email protected]>
Signed-off-by: mingyuanm <[email protected]>
Signed-off-by: mingyuanm <[email protected]>
Signed-off-by: mingyuanm <[email protected]>
Signed-off-by: mingyuanm <[email protected]>
Signed-off-by: Victor49152 <[email protected]>
Signed-off-by: mingyuanm <[email protected]>
…anm/diffusion # Conflicts: # nemo/collections/diffusion/flux/pipeline.py
# Conflicts: # nemo/collections/diffusion/__init__.py # nemo/collections/diffusion/vae/__init__.py
Signed-off-by: mingyuanm <[email protected]>
Signed-off-by: mingyuanm <[email protected]>
Signed-off-by: Victor49152 <[email protected]>
Signed-off-by: mingyuanm <[email protected]>
Signed-off-by: Victor49152 <[email protected]>
Signed-off-by: mingyuanm <[email protected]>
Signed-off-by: Victor49152 <[email protected]>
Signed-off-by: mingyuanm <[email protected]>
Signed-off-by: Victor49152 <[email protected]>
Signed-off-by: mingyuanm <[email protected]>
Signed-off-by: Victor49152 <[email protected]>
Signed-off-by: mingyuanm <[email protected]>
Signed-off-by: mingyuanm <[email protected]>
Signed-off-by: mingyuanm <[email protected]>
Signed-off-by: mingyuanm <[email protected]>
Signed-off-by: mingyuanm <[email protected]>
…_dict # Conflicts: # nemo/collections/diffusion/data/diffusion_mock_datamodule.py # nemo/collections/diffusion/models/flux/model.py # nemo/collections/llm/peft/api.py # nemo/lightning/_strategy_lib.py # nemo/lightning/megatron_parallel.py # scripts/dit/dit_train.py # scripts/flux/flux_controlnet_infer.py # scripts/flux/flux_controlnet_training.py # scripts/flux/flux_infer.py # scripts/flux/flux_training.py
Signed-off-by: mingyuanm <[email protected]>
Signed-off-by: Victor49152 <[email protected]>
Signed-off-by: mingyuanm <[email protected]>
Signed-off-by: mingyuanm <[email protected]>
Signed-off-by: mingyuanm <[email protected]>
Signed-off-by: yaoyu-33 <[email protected]>
Signed-off-by: yaoyu-33 <[email protected]>
Signed-off-by: yaoyu-33 <[email protected]>
Signed-off-by: yaoyu-33 <[email protected]>
Signed-off-by: yaoyu-33 <[email protected]>
…to mingyuanm/flux_controlnet_CI
Signed-off-by: yaoyu-33 <[email protected]>
Signed-off-by: yaoyu-33 <[email protected]>
Signed-off-by: yaoyu-33 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good
Signed-off-by: Yu Yao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12037 +/- ##
==========================================
+ Coverage 30.30% 30.47% +0.17%
==========================================
Files 1387 1397 +10
Lines 176283 177064 +781
Branches 27091 27142 +51
==========================================
+ Hits 53423 53963 +540
- Misses 118776 118991 +215
- Partials 4084 4110 +26 ☔ View full report in Codecov by Sentry. |
[🤖]: Hi @yaoyu-33 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
What does this PR do ?
Add flux recipe for ci
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use this
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information