Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update forward for eval/inference pass in FlowMatching models #12056

Merged
merged 1 commit into from
Feb 15, 2025

Conversation

anteju
Copy link
Collaborator

@anteju anteju commented Feb 5, 2025

What does this PR do ?

This PR disables SSL masking when using forward, and enables SSL masking when using forward_eval which keeps validation masking and can be used in SSL pretraining.

Collection: audio

Changelog

  • Added forward_internal
  • Added forward_eval which will use SSL masking, if available
  • Disable SSL masking when using forward for inference, to avoid the model applying validation masking on the input

Usage

N/A

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the audio label Feb 5, 2025
@anteju anteju added the Run CICD label Feb 5, 2025
@anteju anteju marked this pull request as ready for review February 5, 2025 21:28
@anteju anteju force-pushed the pr/flow-internal-forward branch from 844f285 to 5a382d5 Compare February 5, 2025 21:28
@anteju anteju added Run CICD and removed Run CICD labels Feb 5, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.48%. Comparing base (09186c3) to head (5a382d5).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12056      +/-   ##
==========================================
+ Coverage   30.30%   30.48%   +0.17%     
==========================================
  Files        1387     1395       +8     
  Lines      176283   177070     +787     
  Branches    27091    27147      +56     
==========================================
+ Hits        53423    53980     +557     
- Misses     118776   118982     +206     
- Partials     4084     4108      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anteju anteju force-pushed the pr/flow-internal-forward branch from 5a382d5 to ee72a89 Compare February 7, 2025 18:15
@anteju anteju removed the Run CICD label Feb 7, 2025
@anteju anteju requested review from Kuray107 and racoiaws February 7, 2025 18:15
Copy link
Collaborator

@Kuray107 Kuray107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Collaborator

@racoiaws racoiaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Would be nice to have tests for forward passes
Feel free to merge if you feel it is out of scope for this PR.

@anteju anteju merged commit c54a628 into NVIDIA:main Feb 15, 2025
228 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants