Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AudioToAudioModel: fix model->dataloader sample_rate parameter injection #12092

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

racoiaws
Copy link
Collaborator

@racoiaws racoiaws commented Feb 7, 2025

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

We have code that passes AudioToAudio sample rate parameter to dataloaders, keeping consistency between model "internal" sample rate and incoming dta. In case of lhotse datasets, intepreter doesn't reach this code, returning early.

This PR moves relevant block of code for the config parameter injection to happen before dispatching to initializing lhotse dataloader.

Collection: Audio

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@racoiaws racoiaws self-assigned this Feb 7, 2025
@github-actions github-actions bot added the audio label Feb 7, 2025
anteju
anteju previously approved these changes Feb 7, 2025
Copy link
Collaborator

@anteju anteju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.43%. Comparing base (d56dcd9) to head (71590b3).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12092   +/-   ##
=======================================
  Coverage   30.43%   30.43%           
=======================================
  Files        1400     1400           
  Lines      177498   177498           
  Branches    27203    27203           
=======================================
  Hits        54016    54016           
  Misses     119358   119358           
  Partials     4124     4124           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@racoiaws racoiaws merged commit d2f7b8e into NVIDIA:main Feb 12, 2025
223 checks passed
tomlifu pushed a commit to tomlifu/NeMo that referenced this pull request Feb 20, 2025
…ion (NVIDIA#12092)

* AudioToAudioModel: fix model->dataloader sample_rate parameter injection

Signed-off-by: Roman Korostik <[email protected]>

* AudioToAudioModel: import missing type (PretrainedModelInfo)

Signed-off-by: Roman Korostik <[email protected]>

---------

Signed-off-by: Roman Korostik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants