Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Optimize #12112

Merged
merged 9 commits into from
Feb 9, 2025
Merged

build: Optimize #12112

merged 9 commits into from
Feb 9, 2025

Conversation

ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented Feb 9, 2025

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@ko3n1g ko3n1g added the Run CICD label Feb 9, 2025
@github-actions github-actions bot added the core Changes to NeMo Core label Feb 9, 2025
@ko3n1g ko3n1g force-pushed the ko3n1g/test/flaky-test branch from fd6d9ce to dec1d91 Compare February 9, 2025 12:57
@github-actions github-actions bot added CI and removed core Changes to NeMo Core labels Feb 9, 2025
@ko3n1g ko3n1g added core Changes to NeMo Core Run CICD and removed CI Run CICD labels Feb 9, 2025
@github-actions github-actions bot added CI core Changes to NeMo Core and removed core Changes to NeMo Core labels Feb 9, 2025
@ko3n1g ko3n1g added Run CICD and removed core Changes to NeMo Core Run CICD labels Feb 9, 2025
@github-actions github-actions bot added the core Changes to NeMo Core label Feb 9, 2025
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Feb 9, 2025
@ko3n1g ko3n1g force-pushed the ko3n1g/test/flaky-test branch from 5006077 to 3a1a60c Compare February 9, 2025 14:42
@github-actions github-actions bot removed the CI label Feb 9, 2025
f
Signed-off-by: oliver könig <[email protected]>
f
Signed-off-by: oliver könig <[email protected]>
f
Signed-off-by: oliver könig <[email protected]>
f
Signed-off-by: oliver könig <[email protected]>
f
Signed-off-by: oliver könig <[email protected]>
f
Signed-off-by: oliver könig <[email protected]>
@ko3n1g ko3n1g force-pushed the ko3n1g/test/flaky-test branch from a17ef47 to 6ba5c66 Compare February 9, 2025 15:04
f
Signed-off-by: oliver könig <[email protected]>
@ko3n1g ko3n1g changed the title tests: Disable flaky test build: Optimize Feb 9, 2025
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Feb 9, 2025
f
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Feb 9, 2025
Copy link
Contributor

github-actions bot commented Feb 9, 2025

[🤖]: Hi @ko3n1g 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@ko3n1g ko3n1g merged commit 89bba7b into main Feb 9, 2025
231 checks passed
@ko3n1g ko3n1g deleted the ko3n1g/test/flaky-test branch February 9, 2025 19:14
youngeunkwon0405 pushed a commit to youngeunkwon0405/NeMo that referenced this pull request Feb 10, 2025
* f

Signed-off-by: oliver könig <[email protected]>

* f

Signed-off-by: oliver könig <[email protected]>

* f

Signed-off-by: oliver könig <[email protected]>

* f

Signed-off-by: oliver könig <[email protected]>

* f

Signed-off-by: oliver könig <[email protected]>

* f

Signed-off-by: oliver könig <[email protected]>

* f

Signed-off-by: oliver könig <[email protected]>

* f

Signed-off-by: oliver könig <[email protected]>

* Update test_exp_manager.py

Signed-off-by: oliver könig <[email protected]>

---------

Signed-off-by: oliver könig <[email protected]>
Signed-off-by: Youngeun Kwon <[email protected]>
tomlifu pushed a commit to tomlifu/NeMo that referenced this pull request Feb 20, 2025
* f

Signed-off-by: oliver könig <[email protected]>

* f

Signed-off-by: oliver könig <[email protected]>

* f

Signed-off-by: oliver könig <[email protected]>

* f

Signed-off-by: oliver könig <[email protected]>

* f

Signed-off-by: oliver könig <[email protected]>

* f

Signed-off-by: oliver könig <[email protected]>

* f

Signed-off-by: oliver könig <[email protected]>

* f

Signed-off-by: oliver könig <[email protected]>

* Update test_exp_manager.py

Signed-off-by: oliver könig <[email protected]>

---------

Signed-off-by: oliver könig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Changes to NeMo Core Run CICD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant