Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove getattr_proxy to avoid problematic edge cases #12176

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove getattr_proxy to avoid problematic edge cases #12176

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
885547c
remove getattr_prroxy to avoid problematic edge cases
ashors1 Feb 13, 2025
7aff4d2
Apply isort and black reformatting
ashors1 Feb 13, 2025
57ee683
avoid overwriting class' getattr method
ashors1 Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply isort and black reformatting 
Signed-off-by: ashors1 <[email protected]>
  • Loading branch information
@ashors1
ashors1 committed Feb 13, 2025
commit 7aff4d2a072a21faee6668eb36a5dce9ce466170
1 change: 1 addition & 0 deletions nemo/lightning/megatron_parallel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -867,6 +867,7 @@ def __init__(
def state_dict(self, prefix='', keep_vars=False, **kwargs):
self.module.state_dict(prefix=prefix, keep_vars=keep_vars, **kwargs)


class CallbackConnector:
"""
A connector for managing and invoking callbacks.
Expand Down
Loading