Add cluster to LaunchConfig to support thread block clusters on Hopper
#261
+104
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leofang
added
enhancement
leofang
commented
Dec 3, 2024
leofang
commented
Dec 4, 2024
|
/ok to test |
|
@vzhurba01 this is ready for review |
| if not _use_ex: | ||
| raise CUDAError("thread block clusters require cuda.bindings & driver 11.8+") | ||
| if Device().compute_capability < (9, 0): | ||
| raise CUDAError("thread block clusters are not supported below Hopper") |
There was a problem hiding this comment.
I personally think this message should refer to compute capability rather than archictecture name chronology. ie "thread block clusters require compute capability >=9.0" That is subjective though, I think if we leave it as hopper we should add "(compute capability >= 9.0)"
| dev = Device() | ||
| arch = dev.compute_capability | ||
| if arch < (9, 0): | ||
| print("this demo requires a Hopper GPU (since thread block cluster is a hardware feature)", file=sys.stderr) |
There was a problem hiding this comment.
on the cuda programming guide it indicates that thread block clusters were introduced in cc 9.0 . This seems to indicate that they are exclusive to Hopper. If they are not exclusive to hopper I think we should refer to Compute Capability, or atleast include it and say "Hopper or newer". Personal preference would be >= 9.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #204.