Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to NVML version 11.4 #38

Merged
merged 8 commits into from
Mar 11, 2022
Merged

Bump to NVML version 11.4 #38

merged 8 commits into from
Mar 11, 2022

Conversation

klueska
Copy link
Contributor

@klueska klueska commented Mar 10, 2022

No description provided.

@klueska klueska requested a review from elezar March 10, 2022 14:00
Copy link
Member

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Glad to see the v1 data structs.

* Information about running compute processes on the GPU, legacy version
* for older versions of the API.
*/
typedef struct nvmlProcessInfo_v1_st
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what make the other commits redundant, correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. And I changed things around a bit to add a level of indirection through function pointers rather than branching in the wrapper function. This makes things cleaner as we get to 11.6 and there is yet another ProcessInfo version added.

@elezar elezar self-requested a review March 10, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants