WIP: Some Benchmarks for get_json_object #10729
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <[email protected]>
Signed-off-by: Robert (Bobby) Evans <[email protected]>
abellina
reviewed
Apr 22, 2024
| * limitations under the License. | ||
| */ | ||
|
|
||
| val input = "/data/tmp/SCALE_FROM_JSON" |
abellina
reviewed
Apr 22, 2024
| val numRows = 3000000 | ||
| //val nullProbability = 0.1 | ||
| val nullProbability = 0.0001 | ||
| val output = "/data/tmp/SCALE_FROM_JSON" |
There was a problem hiding this comment.
both input and output assume there's a /data/ folder. That may be fine and can be improved upon later, but perhaps a note would be good?
|
I think it's probably simple to have set of micro benchmarks tied to data gen that in |
|
FYI: we have related benchmark implemented spark-rapids-jni: NVIDIA/spark-rapids-jni#1952 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on #10728 and I don't know if this is where or how we want to deal with benchmarks. I am also happy to move this to another repo if we want to.