HOTFIX: Resolve delivery location fetch issue for off-site items with legacy barcode identifiers #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploy Hold Pages and Special Collections availability messaging to Production
optional chaining on supp content
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dgcohen
changed the title
EdwinGuzman
reviewed
Jan 24, 2025
Yeah, here's a link to the test: https://github.com/NYPL/discovery-front-end/blob/d9a636027c28548f7bd222bf213f05e9a84d618e/test/unit/LibraryItem.test.js#L41 |
charmingduchess
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue that was identified after the launch of the Hold pages, where certain off-site partner records were showing an error on the hold request page.
The issue occurred because the delivery location fetch was failing. This was due to missing functionality in DFE, where barcodes are extracted from the identifier field for bibs with legacy formatting.
This PR adds the necessary functionality to resolve the issue. I've also opened a follow-up ticket to refactor the solution and add unit tests.