fix(db): drop NANGO_DB_MIGRATION_FOLDER (#2901)

## Describe your changes

- Drop NANGO_DB_MIGRATION_FOLDER
I'm not sure why it was necessary but it has caused multiple issues
until now, without clear advantage. Tested locally and the new docker
image.

docker-compose.yaml

@@ -19,7 +19,6 @@ services:
         container_name: nango-server
         platform: linux/amd64
         environment:
-            - NANGO_DB_MIGRATION_FOLDER=/usr/nango-server/src/packages/database/lib/migrations
             - NANGO_ENCRYPTION_KEY=${NANGO_ENCRYPTION_KEY}
             - NANGO_DB_USER=${NANGO_DB_USER}
             - NANGO_DB_PASSWORD=${NANGO_DB_PASSWORD}

packages/cli/docker/docker-compose.yaml

@@ -19,7 +19,6 @@ services:
         container_name: nango-server
         platform: linux/amd64
         environment:
-            - NANGO_DB_MIGRATION_FOLDER=/usr/nango-server/src/packages/database/lib/migrations
             - NANGO_ENCRYPTION_KEY=${NANGO_ENCRYPTION_KEY}
             - NANGO_DB_USER=${NANGO_DB_USER}
             - NANGO_DB_PASSWORD=${NANGO_DB_PASSWORD}

packages/database/lib/index.ts

@@ -1,8 +1,12 @@
+import path from 'node:path';
 import knex from 'knex';
 import type { Knex } from 'knex';
 import { retry } from '@nangohq/utils';
 import { defaultSchema, getDbConfig } from './getConfig.js';
 
+// Note: we are in dist when it executes but migrations are not compiled
+const directory = path.join(import.meta.dirname, '../lib/migrations');
+
 export class KnexDatabase {
     knex: Knex;
 
@@ -11,7 +15,7 @@ export class KnexDatabase {
         this.knex = knex(dbConfig);
     }
 
-    async migrate(directory: string): Promise<any> {
+    async migrate(): Promise<any> {
         return retry(
             async () =>
                 await this.knex.migrate.latest({
@@ -49,15 +53,15 @@ export const multipleMigrations = async (): Promise<void> => {
         await db.knex.raw(`CREATE SCHEMA IF NOT EXISTS ${db.schema()}`);
 
         const [_, pendingMigrations] = await db.knex.migrate.list({
-            directory: String(process.env['NANGO_DB_MIGRATION_FOLDER'])
+            directory
         });
 
         if (pendingMigrations.length === 0) {
             console.log('No pending migrations, skipping migration step.');
         } else {
             console.log('Migrations pending, running migrations.');
             await db.knex.migrate.latest({
-                directory: String(process.env['NANGO_DB_MIGRATION_FOLDER'])
+                directory
             });
             console.log('Migrations completed.');
         }

packages/server/Dockerfile

@@ -1,7 +1,6 @@
 FROM node:20.12.2-slim
 
 ENV SERVER_RUN_MODE=DOCKERIZED
-ENV NANGO_DB_MIGRATION_FOLDER=./packages/database/lib/migrations
 
 RUN apt-get update \
     && apt-get install -y ca-certificates \

packages/server/lib/utils/migrate.ts

@@ -8,7 +8,7 @@ import type { KnexDatabase } from '@nangohq/database';
 export default async function migrate(db: KnexDatabase): Promise<void> {
     logger.info('Migrating database ...');
     await db.knex.raw(`CREATE SCHEMA IF NOT EXISTS ${db.schema()}`);
-    await db.migrate(process.env['NANGO_DB_MIGRATION_FOLDER'] || '../database/lib/migrations');
+    await db.migrate();
     await encryptionManager.encryptDatabaseIfNeeded();
     logger.info('✅ Migrated database');
 }

packages/utils/lib/environment/parse.ts

@@ -90,7 +90,6 @@ export const ENVS = z.object({
                 'To learn more about NANGO_ENCRYPTION_KEY, please read the doc at https://docs.nango.dev/host/self-host/self-hosting-instructions#encrypt-sensitive-data'
         })
         .optional(),
-    NANGO_DB_MIGRATION_FOLDER: z.string().optional(),
     NANGO_DB_SCHEMA: z.string().optional().default('nango'),
     NANGO_DB_ADDITIONAL_SCHEMAS: z.string().optional(),
 

tests/setup.ts

@@ -48,7 +48,6 @@ async function setupPostgres() {
     process.env['NANGO_DB_USER'] = user;
     process.env['NANGO_DB_PORT'] = port.toString();
     process.env['NANGO_DB_NAME'] = dbName;
-    process.env['NANGO_DB_MIGRATION_FOLDER'] = './packages/database/lib/migrations';
     process.env['TELEMETRY'] = 'false';
     process.env['RECORDS_DATABASE_URL'] = `postgres://${user}:${password}@localhost:${port}/${dbName}`;
 }