Skip to content

Commit

Permalink
[Github #652] fix container mapping (#653)
Browse files Browse the repository at this point in the history
* [gh-#652] update docs and use updated shared version

* [gh-#652] bump shared and update docker-compose for now
  • Loading branch information
khaliqgant authored May 31, 2023
1 parent fa02dec commit a0df737
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 7 deletions.
2 changes: 2 additions & 0 deletions docker-compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ services:
container_name: nango-server
volumes:
- './packages/shared/providers.yaml:/usr/nango-server/src/packages/shared/providers.yaml'
environment:
- NANGO_DB_MIGRATION_FOLDER=/usr/nango-server/src/packages/server/lib/db/migrations
restart: always
ports:
- '3003:3003'
Expand Down
8 changes: 7 additions & 1 deletion docs-v2/contribute/nango-auth.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,12 @@ NANGO_CALLBACK_URL=https://redirectmeto.com/http://localhost:3003/oauth/callback

To test your new provider:

Start the docker containers:

```bash
docker compose up
```

The docker compose configuration in the root of the repo `docker-compose.yaml`
will run 2 containers.

Expand All @@ -94,7 +100,7 @@ To propagate your changes after editing the `providers.yaml` file, run:

```bash
docker compose restart nango-server # Force a restart, which will load in the yaml again
docker compose run nango-server cat packages/server/providers.yaml # print the contents of the providers file from inside the container
docker compose run nango-server cat packages/shared/providers.yaml # print the contents of the providers file from inside the container
```

When you are ready to test your new provider template:
Expand Down
6 changes: 3 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/server/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@nangohq/nango-server",
"version": "0.17.1",
"version": "0.17.2",
"description": "Nango OAuth's server.",
"type": "module",
"main": "dist/server.js",
Expand All @@ -21,7 +21,7 @@
},
"dependencies": {
"@hapi/boom": "^10.0.1",
"@nangohq/shared": "^0.1.0",
"@nangohq/shared": "^0.17.2",
"@sentry/node": "^7.37.2",
"axios": "^1.3.4",
"braintree": "^3.15.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@nangohq/shared",
"version": "0.1.0",
"version": "0.17.2",
"description": "Nango's shared components.",
"type": "module",
"main": "dist/lib/index.js",
Expand Down

0 comments on commit a0df737

Please sign in to comment.