Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arm support #2619

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/build-image-reusable.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,10 @@ jobs:

runs-on: ubuntu-latest
env:
CAN_PUSH: "${{ secrets.DOCKER_PASSWORD != ' && secrets.DOCKER_USERNAME != ' }}"
CAN_PUSH: "${{ secrets.DOCKER_PASSWORD != '' && secrets.DOCKER_USERNAME != '' }}"
SHA: ${{ github.event.pull_request.head.sha || github.sha }}
# If you're forking this repo, remember to set DOCKER_REPO_LINK to your docker repo link
REPO_LINK: "${{ secrets.DOCKER_REPO_LINK != '' && secrets.DOCKER_REPO_LINK || 'nangohq/nango' }}"

steps:
- name: Check out
Expand All @@ -52,9 +54,9 @@ jobs:
run: |
export SENTRY_KEY=${{ secrets[inputs.key_for_sentry_secret] }}
export POSTHOG_KEY=${{ secrets[inputs.key_for_posthog_secret] }}
./scripts/build_docker.sh build ${{ inputs.name }} ${{ env.SHA }}
docker buildx build --platform linux/amd64,linux/arm64 -t ${{ env.REPO_LINK }}:${{ inputs.name }}-${{ env.SHA }} --push .

- name: Push image
if: env.CAN_PUSH == 'true'
run: |
docker push nangohq/nango:${{ inputs.name }}-${{ env.SHA }}
docker push ${{ env.REPO_LINK }}:${{ inputs.name }}-${{ env.SHA }}
5 changes: 4 additions & 1 deletion .github/workflows/push-container.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,7 @@ jobs:

npm ci
npm run ${{ inputs.run-cmd }}
docker buildx build -f packages/${{ inputs.package }}/Dockerfile --platform linux/amd64 ${{ inputs.tags }} . --no-cache ${{ env.PUSH }}
docker buildx build -f packages/${{ inputs.package }}/Dockerfile \
--platform linux/amd64,linux/arm64 \
--tag ${{ inputs.tags }} \
. --no-cache ${{ env.PUSH }}
3 changes: 2 additions & 1 deletion docker-compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ services:
nango-server:
image: nangohq/nango-server:hosted
container_name: nango-server
platform: linux/amd64
# Specifying this will break arm support, its optional anyways
# platform: linux/amd64
environment:
- NANGO_DB_MIGRATION_FOLDER=/usr/nango-server/src/packages/database/lib/migrations
- NANGO_ENCRYPTION_KEY=${NANGO_ENCRYPTION_KEY}
Expand Down