Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): enforce max cli version #2957

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bodinsamuel
Copy link
Collaborator

@bodinsamuel bodinsamuel commented Nov 7, 2024

Describe your changes

Fixes https://linear.app/nango/issue/NAN-2097/enforce-maximum-cli-version-on-public-api

Note

This is a proposal

  • Enforce a maximum CLI version tied to the backend version
    It's usually not an issue. But on cloud it's problematic:
  • if people upgrade their CLI and we rollback
  • if we deploy runner and not server
    For enterprises it's worse because they are pinned to a version for months and it's easy to make the mistake of upgrading the CLI but not the backend.

This might be too strict, I'm not sure. let me know

Screenshot 2024-11-07 at 12 24 58

@bodinsamuel bodinsamuel self-assigned this Nov 7, 2024
Copy link

linear bot commented Nov 7, 2024

Copy link
Collaborator

@TBonnin TBonnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea, especially for enterprise customers.

@bodinsamuel
Copy link
Collaborator Author

As discussed with bastien, I might try to enforce only minor versions instead of patch so we can still provide patches for enterprise (eventually) <=0.42.xxx

@TBonnin
Copy link
Collaborator

TBonnin commented Nov 7, 2024

As discussed with bastien, I might try to enforce only minor versions instead of patch so we can still provide patches for enterprise (eventually) <=0.42.xxx

It would then only be useful if we follow proper semantic versioning, which limits a lot the safeguard capability this change is supposed to provide

@bodinsamuel
Copy link
Collaborator Author

It would then only be useful if we follow proper semantic versioning, which limits a lot the safeguard capability this change is supposed to provide

Yeah that's my fear, also I'm not sure we have a way to backfill patches so it's limited.

Copy link
Member

@khaliqgant khaliqgant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should start to follow proper semantic versioning in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants