-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): enforce max cli version #2957
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea, especially for enterprise customers.
As discussed with bastien, I might try to enforce only minor versions instead of patch so we can still provide patches for enterprise (eventually) <=0.42.xxx |
It would then only be useful if we follow proper semantic versioning, which limits a lot the safeguard capability this change is supposed to provide |
Yeah that's my fear, also I'm not sure we have a way to backfill patches so it's limited. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should start to follow proper semantic versioning in this case.
Describe your changes
Fixes https://linear.app/nango/issue/NAN-2097/enforce-maximum-cli-version-on-public-api
Note
This is a proposal
It's usually not an issue. But on cloud it's problematic:
For enterprises it's worse because they are pinned to a version for months and it's easy to make the mistake of upgrading the CLI but not the backend.
This might be too strict, I'm not sure. let me know