fix(CLI): show on-events scripts in nango deploy confirmation message
#3069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bodinsamuel
approved these changes
Nov 27, 2024
| res.added.push({ | ||
| configId: config.id, | ||
| name: script.name, | ||
| version: '0.0.1', |
There was a problem hiding this comment.
Out of curiosity:
Did you talk with Bastien about adding on-events-scripts in the templates, managing their versioning, and being able to enable/disable them via the UI?
There was a problem hiding this comment.
No but that's why I pinged him in a previous PR to mention that there would still be a fair amount of work to support the features you mentioned (pre-built, dasbhoard, etc...) for on-events scripts
TBonnin
force-pushed
the
tbonnin/nan-2219/on-events-cli-output
branch
from
153ca6a
to
3d86040
Compare
Base automatically changed from
tbonnin/nan-2219/on-events-cli-output
to
master
November 27, 2024 13:31
TBonnin
force-pushed
the
tbonnin/nan-2219/cli-on-events-confirmation
branch
from
fcb9633
to
6d5b2e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #3067
The CLI should show the added/deleted on-event scripts in the
nango deployconfirmation message.How to test:
nango install -g PATH/TO/REPO/packages/clion-eventsscripts in your nango.yamlnango deploy devand check the confirmation message show the added/removed scripts