-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(integrations): Add copper integration #3071
feat(integrations): Add copper integration #3071
Conversation
docs-v2/integrations/all/copper.mdx
Outdated
|
||
## API gotchas | ||
|
||
- Copper offers both OAuth and API_KEY authentication modes. To use OAuth2.0 with Copper, you must first register your application. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we also add support for the API key auth as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been added
docs-v2/integrations/all/copper.mdx
Outdated
- You will need to provide the name and purpose of your application as well as a URL to an HTTPS endpoint that will handle the secure callback. | ||
You will receive two credentials, client_id and client_secret, required for all authorization flows. | ||
|
||
- The Dev API uses token based authentication. You have to include the token in the header of every request, along with the email address of the user who generated the token. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dannylwe where in their documentation is this specified? Shouldn't we inject this for the user if this is the case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khaliqgant Makes sense. This should be injected for the user
packages/shared/providers.yaml
Outdated
auth_mode: OAUTH2 | ||
proxy: | ||
base_url: https://api.copper.com/developer_api/ | ||
docs: https://docs.nango.dev/integrations/all/copper |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be helpful to include the docs link at the end.
@khaliqgant, should we also start documenting for |
Yes, absolutely. Thanks for bringing this up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes requested inline
is it okay to merge? |
No description provided.