Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(integrations): Add copper integration #3071

Merged
merged 16 commits into from
Dec 2, 2024

Conversation

dannylwe
Copy link
Contributor

No description provided.

Copy link

linear bot commented Nov 27, 2024

@dannylwe dannylwe marked this pull request as ready for review November 29, 2024 09:21
@dannylwe dannylwe requested review from a team November 29, 2024 09:22
@dannylwe dannylwe changed the title feat(copper): integration feat(copper): Add copper integration Nov 29, 2024
@bodinsamuel bodinsamuel changed the title feat(copper): Add copper integration feat(integrations): Add copper integration Nov 29, 2024

## API gotchas

- Copper offers both OAuth and API_KEY authentication modes. To use OAuth2.0 with Copper, you must first register your application.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we also add support for the API key auth as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been added

- You will need to provide the name and purpose of your application as well as a URL to an HTTPS endpoint that will handle the secure callback.
You will receive two credentials, client_id and client_secret, required for all authorization flows.

- The Dev API uses token based authentication. You have to include the token in the header of every request, along with the email address of the user who generated the token.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dannylwe where in their documentation is this specified? Shouldn't we inject this for the user if this is the case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khaliqgant Makes sense. This should be injected for the user

auth_mode: OAUTH2
proxy:
base_url: https://api.copper.com/developer_api/
docs: https://docs.nango.dev/integrations/all/copper
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be helpful to include the docs link at the end.

@hassan254-prog
Copy link
Contributor

@khaliqgant, should we also start documenting for connect-ui now to prevent the need to backfill these docs in the future?

@khaliqgant
Copy link
Member

@khaliqgant, should we also start documenting for connect-ui now to prevent the need to backfill these docs in the future?

Yes, absolutely. Thanks for bringing this up.

@khaliqgant khaliqgant self-requested a review November 29, 2024 14:10
Copy link
Member

@khaliqgant khaliqgant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested inline

@bodinsamuel
Copy link
Collaborator

is it okay to merge?

@khaliqgant khaliqgant enabled auto-merge (squash) December 2, 2024 09:14
@khaliqgant khaliqgant merged commit fa56a6e into master Dec 2, 2024
20 checks passed
@khaliqgant khaliqgant deleted the daniellwetabe/ext-264-add-cooper-integration branch December 2, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants