feat(api): expose credentials in GET /integrations/:uniqueKey #3074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalanj
approved these changes
Nov 27, 2024
TBonnin
reviewed
Nov 27, 2024
packages/types/lib/utils.ts
Outdated
|
|
||
| export type NullablePartial< | ||
| TBase, | ||
| NK extends keyof TBase = { [K in keyof TBase]: null extends TBase[K] ? K : never }[keyof TBase], |
There was a problem hiding this comment.
I would rename NK TNullableKey to follow the same pattern and make it a bit more descriptive
TBonnin
reviewed
Nov 27, 2024
packages/types/lib/utils.ts
Outdated
| TBase, | ||
| NK extends keyof TBase = { [K in keyof TBase]: null extends TBase[K] ? K : never }[keyof TBase], | ||
| NP = Partial<Pick<TBase, NK>> & Pick<TBase, Exclude<keyof TBase, NK>> | ||
| > = { [K in keyof NP]: NP[K] }; |
There was a problem hiding this comment.
not sure you need NP. can we have
export type NullablePartial<
TBase,
TNullableKeys ...
> = Omit<TBase, TNullableKeys> & Partial<Pick<TBase, TNullableKeys>>
There was a problem hiding this comment.
You forgot to add the non nullable keys, but yes I can simplify indeed
TBonnin
approved these changes
Nov 27, 2024
bodinsamuel
deleted the
sam/24_11_27/feat/get-integration-credentials
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
GET /integrations/:uniqueKeynow expose credentials (optional)Some customers need the credentials for internal operations or oauth revoke. This expose optionally the credentials with some added security.
Try to fix IntegrationConfig type by creating a smaller scope for integration create
This type is annoying, it's used a bit everywhere and everything is marked as undefined except it's null not undefined. Anyway, first steps since I needed better types.