fix(api): improve user model usage #3076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalanj
approved these changes
Nov 29, 2024
| @@ -10,6 +10,7 @@ import { OrchestratorClient } from '@nangohq/nango-orchestrator'; | |||
|
|
|||
| const logger = getLogger('Server.Utils'); | |||
|
|
|||
| /** @deprecated TODO delete this */ | |||
There was a problem hiding this comment.
Would it make sense to just knock this out? It's only used in a couple of spots right now.
There was a problem hiding this comment.
Yes but I wasn't sure about the fix, just noted for later
TBonnin
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Extracted from #3072
Clarify our use of user's session
req.useris painful because session can be out of date, and it's hard to add/remove fields from session. It's easier to always use `res.locals[user] that's always fresh.Pass UUID, will be used later
Fix regex for integration tests