feat: Adds personio_v2 provider #3089
Conversation
tonibardina
changed the title
| sidebarTitle: Personio (v2) | ||
| --- | ||
|
|
||
| API configurations: [`personio`](https://nango.dev/providers.yaml) |
There was a problem hiding this comment.
I think you can remove this page and just add personio-v2 in personio.mdx
There was a problem hiding this comment.
Hey @bodinsamuel I just wonder if we can merge both since they are slightly different:
personio:
display_name: Personio
categories:
- hr
auth_mode: OAUTH2_CC
proxy:
base_url: https://api.personio.de/v1
headers:
x-personio-partner-id: ${connectionConfig.partnerId}
x-personio-app-id: ${connectionConfig.appId}
token_url: https://api.personio.de/v1/auth
body_format: json
docs: https://docs.nango.dev/integrations/all/personio
connection_config:
partnerId:
type: string
title: Partner ID
description: The partner ID of your Personio account
appId:
type: string
title: App ID
description: The app ID of your Personio account
personio-v2:
display_name: Personio (v2)
categories:
- hr
auth_mode: OAUTH2_CC
proxy:
base_url: https://api.personio.de/v2
headers:
Content-Type: application/x-www-form-urlencoded
token_url: https://api.personio.de/v2/auth/token
scope_separator: ' '
docs: https://docs.nango.dev/integrations/all/personio
token_params:
grant_type: client_credentialsThere was a problem hiding this comment.
Good point. Maybe we should create a v2 section in the same doc.
There was a problem hiding this comment.
Do you have any example of an integration where multiple versions are explained so I can make sure we are being consistent on how things are shown?
There was a problem hiding this comment.
We never did it so I guess something simple like
## API v2
[... requirements]
There was a problem hiding this comment.
Hey @bodinsamuel actually there were no big differences between both versions from the nango perspective. What I have done is adding a Api V1 tag to the requirements that are specific for that version
<!-- Describe the problem and your solution --> The base url for the `Personio` provider was including the `v1` path so I was not able to make calls to the the `v2` of the api. To not break it for the current users I have followed the same approach that you have used with the twitter api and decided to create the provider for the api `v2` version. --------- Co-authored-by: Samuel Bodin <[email protected]>
The base url for the
Personioprovider was including thev1path so I was not able to make calls to the thev2of the api. To not break it for the current users I have followed the same approach that you have used with the twitter api and decided to create the provider for the apiv2version.