Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: API docs page outline #3093

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

docs: API docs page outline #3093

wants to merge 2 commits into from

Conversation

bastienbeurier
Copy link
Member

  • Example API page
  • New edits based on feedback

Copy link
Member

@rguldener rguldener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bastienbeurier I left some comments on wording, let me know what you think!

| - | - |
| Pre-built authorization (OAuth 2) | ✅ |
| Credentials auto-refresh | ✅ |
| Authorization input validation | ✅ |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% sure which feature you refer to, is it the automatic credentials validation?
If you also mean the additional parameters, I think we should mention them explicitly as a separate feature?

Suggestion:
Automatic credentials validation
Automatic auth-parameters validation

| Pre-built authorization (OAuth 2) | ✅ |
| Credentials auto-refresh | ✅ |
| Authorization input validation | ✅ |
| Pre-built authorization UI | ✅ |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-built Connect UI?

To stay in line with our wording of this feature elsewhere

| Authorization input validation | ✅ |
| Pre-built authorization UI | ✅ |
| Custom authorization UI | ✅ |
| End-user authorization guidelines | ✅ |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

End-user authorization guide

=> IMO we should only mark it as checked where we actually have it. For OAuth ones, we could mark as "not required"?

| Pre-built authorization UI | ✅ |
| Custom authorization UI | ✅ |
| End-user authorization guidelines | ✅ |
| Invalid credentials detection | ✅ |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broken credentials detection

I would use this wording to differentiate between the validation at connect time, and detection of broken credentials down the road

| - | - |
| HTTP request logging | ✅ |
| End-to-type type safety | ✅ |
| Data runtime validation | ✅ |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bastienbeurier Since we mention some platform level features here, IMO we could add:

  • OpenTelemetry export
  • Slack Alerts on errors
  • Integration status API


<Tip>Not seeing the use-case you need? [Build your own](https://nango.dev/slack) independently.</Tip>

## Pre-requisites
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never heard of pre-requisites before. I think it would be good to find a more descriptive title

Suggestion:
Requirements & Review Process

Also open to other suggestions!

| Pre-Requisites | Status | Comment|
| - | - | - |
| Paid dev account | ✅ Not required | Free, self-signup [here](https://developers.hubspot.com/). |
| Paid test account | ✅ Not required | Free, self-signup [here](https://hubspot.com/). |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Once you have a dev account you can create a free Enterprise HubSpot account. That will be more realistic account for testing than the free account.
I would change the comment to "Create free Enterprise account for testing from your developer account"

| Paid dev account | ✅ Not required | Free, self-signup [here](https://developers.hubspot.com/). |
| Paid test account | ✅ Not required | Free, self-signup [here](https://hubspot.com/). |
| Partnership | ✅ Not required | |
| App review | ✅ Not required | |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add in comment "Only required for marketplace listing, not for integration distribution"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants