Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(providers): allow fields to be marked as automated #3094

Merged

Conversation

bodinsamuel
Copy link
Collaborator

@bodinsamuel bodinsamuel commented Dec 2, 2024

Changes

Fixes https://linear.app/nango/issue/NAN-2280/ability-to-set-connectionconfig-as-automated

  • Allow fields to be marked as automated
  • Set salesforce instance url as automated

Tests

I don't have a Salesforce account, if you have one I would appreciate a local test please (@khaliqgant or @hassan254-prog)

@bodinsamuel bodinsamuel self-assigned this Dec 2, 2024
Copy link

linear bot commented Dec 2, 2024

@hassan254-prog
Copy link
Contributor

Changes

Fixes https://linear.app/nango/issue/NAN-2280/ability-to-set-connectionconfig-as-automated

  • Allow fields to be marked as automated
  • Set salesforce instance url as automated

Tests

I don't have a Salesforce account, if you have one I would appreciate a local test please (@khaliqgant or @hassan254-prog)

@bodinsamuel, checking 👍.

@hassan254-prog
Copy link
Contributor

@bodinsamuel , works perfect with salesforce 👍

@bodinsamuel bodinsamuel enabled auto-merge (squash) December 2, 2024 21:10
@bodinsamuel bodinsamuel merged commit 58f2683 into master Dec 2, 2024
20 checks passed
@bodinsamuel bodinsamuel deleted the sam/24_12_02/fix/salesforce-automated-instance-url branch December 2, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants