ci: split CLI/Node tests #3096
Merged
ci: split CLI/Node tests #3096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBonnin
approved these changes
Dec 3, 2024
I don't think there is much speed gain here since stuff were running in parallel. Windows still takes a long time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes https://linear.app/nango/issue/NAN-2181/ci-split-all-cli-node-client-out-of-main-tests-suite
Split CLI and node client tests and execute in a dedicated matrix
They run 6 tests (Node 18, 20, 22 x windows or ubuntu). It's a lot but seems relatively fast. Alternatively we could make windows matrix only execute on master.
We could further optimize this and run them only types or node or cli has changed but it's a pain to create this kind of logic.
Integration and regular tests only run on Ubuntu + .nvmrc
This doesn't save much time since the matrix was running in parallel but reduce potential for flaky tests