Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(integrations): add support for eBay #3099

Merged
merged 5 commits into from
Dec 4, 2024

Conversation

cassanelligiovanni
Copy link
Contributor

##Describe your changes

Added configuration for ebay and ebay-sandbox in providers.yaml
Added ebay to docs-v2.
Added ebay pages for Supported API groups in mint.json.
Added ebay and ebay-sandbox SVG file in template-logos folder.
Consolidate Ebay docs pages

##Test

This provider has been used successfully in local development to connect to Ebay Sandbox API and Ebay API and successfully call those endpoints after authorizing using Nango. (Have not tested sync and actions)

@bodinsamuel bodinsamuel changed the title Added OAuth Ebay Integration feat(integrations): add suport for eBay Dec 3, 2024
Copy link
Collaborator

@bodinsamuel bodinsamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution 🙏🏻
Small comments but otherwise looks good

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you use a symlink instead please? ☺️

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can i create a symlink? do you have examples of past contributions? Cause i was looking at Brex integration and they have 2 identical logos

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can create a symbolic link with the following command within the templates-logos folder
ln -s ebay.svg ebay-sandbox.svg

packages/shared/providers.yaml Show resolved Hide resolved
@bodinsamuel bodinsamuel requested a review from a team December 3, 2024 15:22
@cassanelligiovanni cassanelligiovanni changed the title feat(integrations): add suport for eBay feat(integrations): add support for eBay Dec 3, 2024
Copy link
Collaborator

@bodinsamuel bodinsamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, merging that and deploying during the day 👍🏻

@bodinsamuel bodinsamuel enabled auto-merge (squash) December 4, 2024 10:48
@khaliqgant khaliqgant merged commit cf99e95 into NangoHQ:master Dec 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants