-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(integrations): add support for eBay #3099
feat(integrations): add support for eBay #3099
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution 🙏🏻
Small comments but otherwise looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you use a symlink instead please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can i create a symlink? do you have examples of past contributions? Cause i was looking at Brex integration and they have 2 identical logos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can create a symbolic link with the following command within the templates-logos
folder
ln -s ebay.svg ebay-sandbox.svg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, merging that and deploying during the day 👍🏻
##Describe your changes
Added configuration for
ebay
andebay-sandbox
in providers.yamlAdded
ebay
to docs-v2.Added
ebay
pages for Supported API groups in mint.json.Added
ebay
andebay-sandbox
SVG file in template-logos folder.Consolidate Ebay docs pages
##Test
This provider has been used successfully in local development to connect to Ebay Sandbox API and Ebay API and successfully call those endpoints after authorizing using Nango. (Have not tested sync and actions)