fix(proxy): handle more content-disposition edge cases #3100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bodinsamuel
reviewed
Dec 3, 2024
bodinsamuel
approved these changes
Dec 3, 2024
khaliqgant
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the response handling to cover more edge cases. Instead of checking if the
content-dispositionheader is exactly equal toattachment, we now check if it includesattachmentorinline, allowing for more flexibility. This change improves the handling of different content types by considering both attachment and inline dispositions.Initially this was producing a malformed response with the dropbox and front providers, but after the fix, it works as expected.