Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): Load errorLog regardless of credential refresh result #3103

Merged
merged 1 commit into from
Dec 3, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -83,31 +83,18 @@ export const getConnection = asyncWrapper<GetConnection>(async (req, res) => {
onRefreshSuccess: connectionRefreshSuccessHook,
onRefreshFailed: connectionRefreshFailedHook
});
if (credentialResponse.isErr()) {
const errorLog = await errorNotificationService.auth.get(connection.id!);

// When we failed to refresh we still return a 200 because the connection is used in the UI
// Ultimately this could be a second endpoint so the UI displays faster and no confusion between error code
res.status(200).send({
data: {
errorLog,
provider: integration.provider,
connection: connectionFullToApi(connection as DBConnection),
endUser: endUserToApi(endUser)
}
});

return;
if (credentialResponse.isOk()) {
connection = credentialResponse.value;
}

connection = credentialResponse.value;
const errorLog = await errorNotificationService.auth.get(connection.id!);

res.status(200).send({
data: {
provider: integration.provider,
connection: connectionFullToApi(connection as DBConnection),
endUser: endUserToApi(endUser),
errorLog: null
errorLog
}
});
});
Loading