Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(providers): improve validation for connect #3109

Merged
merged 2 commits into from
Dec 4, 2024
Merged

fix(providers): improve validation for connect #3109

merged 2 commits into from
Dec 4, 2024

Conversation

bodinsamuel
Copy link
Collaborator

Changes

Improve validation for providers

  • Detect invalid path
  • Detect missing doc_connect
  • Detect invalid doc_section

@bodinsamuel bodinsamuel self-assigned this Dec 4, 2024
@bodinsamuel bodinsamuel requested a review from a team December 4, 2024 10:47
khaliqgant
khaliqgant approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@khaliqgant khaliqgant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks

@bodinsamuel bodinsamuel enabled auto-merge (squash) December 4, 2024 13:16
@bodinsamuel bodinsamuel merged commit cf6cd57 into master Dec 4, 2024
21 checks passed
@bodinsamuel bodinsamuel deleted the sam/24_12_04/fix/providers-validation-for-connect branch December 4, 2024 13:16
@hassan254-prog hassan254-prog mentioned this pull request Dec 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khaliqgant khaliqgant khaliqgant approved these changes

Assignees

@bodinsamuel bodinsamuel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bodinsamuel @khaliqgant