Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(providers): enforce lowercase headers, enforce categories #3110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bodinsamuel
Copy link
Collaborator

Changes

  • enforce lowercase headers
    Headers are case insensitive, but that's annoying when we manipulate those strings against axios/fetch that always lowercase headers
  • enforce categories name

@bodinsamuel bodinsamuel self-assigned this Dec 4, 2024
Copy link
Collaborator

@TBonnin TBonnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine by me. Are we sure no logic relies on the case though?

@bodinsamuel
Copy link
Collaborator Author

bodinsamuel commented Dec 4, 2024

fine by me. Are we sure no logic relies on the case though?

It's in reaction of #3108 this is the only place those headers are used (and proxy obv)

Copy link
Contributor

@nalanj nalanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌🏻 I bumped into header casing on this testing PR I've been working on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants