fix(tests): Fix broken integration test that never fails in CI

[nalanj]

This was a weird one. Since I've joined I've always had some tests that fail on my computer but never fail in CI. There's another that's flaky for me, but I can't seem to get it to fail right now.

This test was failing for me:

nango/packages/server/lib/controllers/connect/postSessions.integration.test.ts

Lines 101 to 139 in 053d636

	it('should update the end user if needed', async () => {
	// first request create an end user
	const endUserId = 'knownId';
	const res = await api.fetch(endpoint, {
	method: 'POST',
	token: seed.env.secret_key,
	body: { end_user: { id: endUserId, email: '[email protected]' } }
	});
	isSuccess(res.json);
	// second request with same endUserId update the end user
	const newEmail = '[email protected]';
	const newDisplayName = 'Mr XY';
	const newOrgId = 'orgId';
	const newOrgDisplayName = 'OrgName';
	const res2 = await api.fetch(endpoint, {
	method: 'POST',
	token: seed.env.secret_key,
	body: {
	end_user: {
	id: endUserId,
	email: newEmail,
	display_name: newDisplayName
	},
	organization: { id: newOrgId, display_name: newOrgDisplayName }
	}
	});
	isSuccess(res2.json);
	const getEndUser = await endUserService.getEndUser(db.knex, {
	endUserId: endUserId,
	accountId: seed.env.account_id,
	environmentId: seed.env.id
	});
	const endUser = getEndUser.unwrap();
	expect(endUser.email).toBe(newEmail);
	expect(endUser.displayName).toBe(newDisplayName);
	expect(endUser.organization?.organizationId).toBe(newOrgId);
	expect(endUser.organization?.displayName).toBe(newOrgDisplayName);
	});

The source of the issue, I found, was that we were replying in the server inside of a transaction block, so the transaction hadn't finalized by the time that my request replied and the test checked that the database was updated. This PR pulls the http response sending outside of the transaction block to make sure everything times out correctly.

I couldn't find any other examples where we did this.

How I tested it

Run the tests!

[TBonnin]

lgtm. This is probably not the only place in the codebase where we send response back from inside a db transaction

[nalanj]

@TBonnin I actually dug around some and couldn't find any other instances, but that was also my assumption.

[bodinsamuel]

Indeed