Skip to content

Commit

Permalink
Run tests only with the js parser instead of hiredis and js parser fr…
Browse files Browse the repository at this point in the history
…om now on

This removes the optional-dev-dependency as this is not needed from now on anymore
  • Loading branch information
Ruben Bridgewater committed Apr 29, 2016
1 parent 0dc45bd commit f500398
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
2 changes: 0 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
"coverage": "nyc report --reporter=html",
"benchmark": "node benchmarks/multi_bench.js",
"test": "nyc --cache mocha ./test/*.js ./test/commands/*.js --timeout=8000",
"pretest": "optional-dev-dependency hiredis",
"posttest": "eslint . --fix"
},
"dependencies": {
Expand All @@ -40,7 +39,6 @@
"metrics": "^0.1.9",
"mocha": "^2.3.2",
"nyc": "^6.0.0",
"optional-dev-dependency": "^1.1.0",
"tcp-port-used": "^0.1.2",
"uuid": "^2.0.1",
"win-spawn": "^2.0.0"
Expand Down
9 changes: 5 additions & 4 deletions test/helper.js
Original file line number Diff line number Diff line change
Expand Up @@ -163,10 +163,11 @@ module.exports = {
}
var parsers = ['javascript'];
var protocols = ['IPv4'];
try {
require('hiredis');
parsers.push('hiredis');
} catch (e) {/* ignore eslint */}
// The js parser works the same as the hiredis parser, just activate this if you want to be on the safe side
// try {
// require('hiredis');
// parsers.push('hiredis');
// } catch (e) {/* ignore eslint */}
if (process.platform !== 'win32') {
protocols.push('IPv6', '/tmp/redis.sock');
}
Expand Down

0 comments on commit f500398

Please sign in to comment.