Skip to content

Commit

Permalink
remove print from error handling code (tableau#439)
Browse files Browse the repository at this point in the history
* remove print from error handling code

* remove & for linux cmd

Co-authored-by: Olek Golovatyi <[email protected]>
0golovatyi and Olek Golovatyi authored Aug 13, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
1 parent 887b963 commit 6e46d31
Showing 3 changed files with 2 additions and 6 deletions.
2 changes: 1 addition & 1 deletion tabpy/tabpy_server/common/default.conf
Original file line number Diff line number Diff line change
@@ -47,7 +47,7 @@ propagete=0

[handler_rootHandler]
class=StreamHandler
level=DEBUG
level=INFO
formatter=rootFormatter
args=(sys.stdout,)

4 changes: 0 additions & 4 deletions tabpy/tabpy_server/handlers/base_handler.py
Original file line number Diff line number Diff line change
@@ -138,10 +138,6 @@ def error_out(self, code, log_message, info=None):
self.set_status(code)
self.write(json.dumps({"message": log_message, "info": info or {}}))

# We want to duplicate error message in console for
# loggers are misconfigured or causing the failure
# themselves
print(info)
self.logger.log(
logging.ERROR,
'Responding with status={}, message="{}", info="{}"'.format(
2 changes: 1 addition & 1 deletion tests/integration/integ_test_base.py
Original file line number Diff line number Diff line change
@@ -169,7 +169,7 @@ def _get_config_file_name(self) -> str:
config_file = open(os.path.join(self.tmp_dir, "test.conf"), "w+")
config_file.write(
"[TabPy]\n"
f"TABPY_QUERY_OBJECT_PATH = ./query_objects\n"
f"TABPY_QUERY_OBJECT_PATH = {self.tmp_dir}/query_objects\n"
f"TABPY_PORT = {self._get_port()}\n"
f"TABPY_STATE_PATH = {self.tmp_dir}\n"
)

0 comments on commit 6e46d31

Please sign in to comment.