Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows Installer build. #1032

Merged
merged 1 commit into from
Feb 23, 2025
Merged

Conversation

acolwell
Copy link
Collaborator

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:

PR Description

What type of PR is this? (Check one of the boxes below)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality nor fixes a bug but improves Natron in some way)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
    • I have updated the documentation accordingly

What does this pull request do?

The msys2 rav1e package recently renamed its DLL with a lib prefix. msys2/MINGW-packages@182707e

This change adds the prefix to the relevant installer code.

Have you tested your changes (if applicable)? If so, how?

Yes. The windows installer successfully builds again (https://github.com/acolwell/Natron/actions/runs/13479836742)

The msys2 rav1e package recently renamed its DLL with a lib prefix.
msys2/MINGW-packages@182707e

This change adds the prefix to the relevant installer code.
@rodlie rodlie merged commit 8e6ac6f into NatronGitHub:RB-2.6 Feb 23, 2025
3 checks passed
@acolwell acolwell deleted the fix_windows_build branch February 23, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants