patched/removed invalid role value tree-item; fixed loader svg attrib…

…utes
NeatNerdPrime · Jul 29, 2020 · 58abc79 · 58abc79
1 parent 571bc2c
commit 58abc79
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/Services/Block/js/ilblockcallback.js b/Services/Block/js/ilblockcallback.js
@@ -75,7 +75,7 @@ function ilBlockJSHandler(block_id, sUrl)
 	{
 		var loadergif = document.createElement('img');
 		loadergif.src = "./templates/default/images/loader.svg";
-		loadergif.border = 0;
+		loadergif.alt = "";
 		$(loadergif).css("position", "absolute");
 		obj.appendChild(loadergif);
 	}

diff --git a/libs/bower/bower.json b/libs/bower/bower.json
@@ -123,7 +123,7 @@
       "developer": "akill",
       "purpose": "",
       "last-update-for-ilias": "5.4.0",
-      "note": "The former patch (ILIAS < 5.4.0) is not needed anymore. Use of size() has been removed from the lib."
+      "note": "Accessibility/Valid HTML: Remove role='tree-item' from code, since this is an invalid role value."
     },
     "moment": {
       "introduction-date": null,

diff --git a/libs/bower/bower_components/jstree/dist/jstree.js b/libs/bower/bower_components/jstree/dist/jstree.js
@@ -593,7 +593,7 @@
 					return this.nodeType === 3 && (!this.nodeValue || /^\s+$/.test(this.nodeValue));
 				})
 				.remove();
-			this.element.html("<"+"ul class='jstree-container-ul jstree-children' role='group'><"+"li id='j"+this._id+"_loading' class='jstree-initial-node jstree-loading jstree-leaf jstree-last' role='tree-item'><i class='jstree-icon jstree-ocl'></i><"+"a class='jstree-anchor' href='#'><i class='jstree-icon jstree-themeicon-hidden'></i>" + this.get_string("Loading ...") + "</a></li></ul>");
+			this.element.html("<"+"ul class='jstree-container-ul jstree-children' role='group'><"+"li id='j"+this._id+"_loading' class='jstree-initial-node jstree-loading jstree-leaf jstree-last' ><i class='jstree-icon jstree-ocl'></i><"+"a class='jstree-anchor' href='#'><i class='jstree-icon jstree-themeicon-hidden'></i>" + this.get_string("Loading ...") + "</a></li></ul>");
 			this.element.attr('aria-activedescendant','j' + this._id + '_loading');
 			this._data.core.li_height = this.get_container_ul().children("li").first().outerHeight() || 24;
 			this._data.core.node = this._create_prototype_node();

diff --git a/libs/bower/bower_components/jstree/dist/jstree.min.js b/libs/bower/bower_components/jstree/dist/jstree.min.js
diff --git a/libs/bower/bower_components/jstree/src/jstree.js b/libs/bower/bower_components/jstree/src/jstree.js
@@ -593,7 +593,7 @@
 					return this.nodeType === 3 && (!this.nodeValue || /^\s+$/.test(this.nodeValue));
 				})
 				.remove();
-			this.element.html("<"+"ul class='jstree-container-ul jstree-children' role='group'><"+"li id='j"+this._id+"_loading' class='jstree-initial-node jstree-loading jstree-leaf jstree-last' role='tree-item'><i class='jstree-icon jstree-ocl'></i><"+"a class='jstree-anchor' href='#'><i class='jstree-icon jstree-themeicon-hidden'></i>" + this.get_string("Loading ...") + "</a></li></ul>");
+			this.element.html("<"+"ul class='jstree-container-ul jstree-children' role='group'><"+"li id='j"+this._id+"_loading' class='jstree-initial-node jstree-loading jstree-leaf jstree-last'><i class='jstree-icon jstree-ocl'></i><"+"a class='jstree-anchor' href='#'><i class='jstree-icon jstree-themeicon-hidden'></i>" + this.get_string("Loading ...") + "</a></li></ul>");
 			this.element.attr('aria-activedescendant','j' + this._id + '_loading');
 			this._data.core.li_height = this.get_container_ul().children("li").first().outerHeight() || 24;
 			this._data.core.node = this._create_prototype_node();