-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 支持 onError 获取 error 对象 #16674
Open
czewail
wants to merge
1
commit into
NervJS:main
Choose a base branch
from
czewail:next
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: 支持 onError 获取 error 对象 #16674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16674 +/- ##
========================================
Coverage 58.51% 58.51%
========================================
Files 466 466
Lines 27115 27115
Branches 5894 5736 -158
========================================
Hits 15866 15866
- Misses 9895 9896 +1
+ Partials 1354 1353 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
This was referenced Oct 12, 2024
This was referenced Oct 26, 2024
This was referenced Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么? (简要描述所做更改)
onError 添加参数,返回原始 error 对象
我们做错误监控的时候捕获了 onError 的对象,但是由于返回的是一个字符串无法解析,里面包含了 statck 的信息,会导致错误聚合问题
这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台: