Skip to content

Commit

Permalink
mpg123: update to 1.26.5 and use default optimization
Browse files Browse the repository at this point in the history
This approaches a serious performance issue with 1.26.x when
resampling is used on certain platforms (observed on SPARC).
Floating point denormals crop up. This change approaches that
two-fold

1. Do not disable default optimization flags for GCC.
2. Update to 1.26.5 that contains code to avoid denormals.

The default flags are about code optimization (like -ffast-math),
not the target architecture, so should not affect portability.
They are also rather safe and tested as development of mpg123
always has them in place. This is how it is meant to be played;-)

Approved during freeze by wiz.
  • Loading branch information
thor committed Mar 25, 2021
1 parent 647807b commit b9cddd2
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 8 deletions.
5 changes: 2 additions & 3 deletions audio/mpg123/Makefile.common
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
# $NetBSD: Makefile.common,v 1.56 2021/01/03 15:06:00 adam Exp $
# $NetBSD: Makefile.common,v 1.57 2021/03/25 23:53:13 thor Exp $
#
# used by audio/mpg123-nas/Makefile
# used by audio/mpg123-oss/Makefile
# used by audio/mpg123-pulse/Makefile
# used by audio/mpg123-sun/Makefile

DISTNAME= mpg123-1.26.4
DISTNAME= mpg123-1.26.5
PKGNAME?= ${DISTNAME:C/[[:alnum:]]*/&-${MPG123_MODULE}/}
CATEGORIES= audio
MASTER_SITES= ${MASTER_SITE_SOURCEFORGE:=mpg123/}
Expand All @@ -21,7 +21,6 @@ USE_LIBTOOL?= yes
USE_TOOLS+= pkg-config gmake
GNU_CONFIGURE?= yes
CONFIGURE_ARGS+= --enable-modules=yes
CONFIGURE_ARGS+= --with-optimization=0 # our CFLAGS are good enough
CONFIGURE_ENV+= BUILD_${MPG123_MODULE:tu}=yes
CONFIGURE_ENV+= MPG123_MODULE=${MPG123_MODULE:Q}

Expand Down
10 changes: 5 additions & 5 deletions audio/mpg123/distinfo
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
$NetBSD: distinfo,v 1.55 2021/01/03 15:06:00 adam Exp $
$NetBSD: distinfo,v 1.56 2021/03/25 23:53:13 thor Exp $

SHA1 (mpg123-1.26.4.tar.bz2) = d6f68d8defbb0622c677d29251a7e81df62cd32f
RMD160 (mpg123-1.26.4.tar.bz2) = ad42a3d4376b993aafc641596233bbc1b8876d1f
SHA512 (mpg123-1.26.4.tar.bz2) = 425162227aafb99b8723428fe9bd403739a2dd68828b86a2cff7f9928a9f0ab3f67420e56c0abe7c9deeb94bce6c6acd59acaa0606ce24c01716465640564785
Size (mpg123-1.26.4.tar.bz2) = 1050563 bytes
SHA1 (mpg123-1.26.5.tar.bz2) = c4ed8d5b0c5400c28198e32b1175c8dac898e569
RMD160 (mpg123-1.26.5.tar.bz2) = 5b433e97f34d2ce5f347bc952671601aaea034bc
SHA512 (mpg123-1.26.5.tar.bz2) = 0c2b3174c834e4bd459a3324b825d9bf9341a3486c0af815773b00cb007578cb718522ac4e983c7ad7e3bb5df9fdd342a03cb51345c41f68971145196ac04b7a
Size (mpg123-1.26.5.tar.bz2) = 1051356 bytes
SHA1 (patch-Makefile.in) = e1b529e9468994e25c2567df7e64a2905b0cf529
SHA1 (patch-aa) = 4b2761219dd8fb92079d7f96872e56beb702696a
SHA1 (patch-ad) = f07b637c3fc1d3ea0426013fc25bca8e3aecba56
Expand Down

0 comments on commit b9cddd2

Please sign in to comment.