[fix] Optional belongs_to #210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llenodo
reviewed
May 14, 2018
| @@ -149,6 +149,7 @@ def get_included_records(record, includes_list, known_included_objects, params = | |||
| included_records.concat(serializer_records) unless serializer_records.empty? | |||
| end | |||
|
|
|||
| next unless inc_obj | |||
There was a problem hiding this comment.
I ran into the same error. Seems like they're trying to solve the issue above on line 144:
included_objects = [included_objects] unless relationship_type == :has_many
next if included_objects.blank?
The problem is that included_objects is an array containing an emtpy element [nil]
I think if we just switch the order of the above 2 methods it will solve the problem and then you dont need to add this nil check
next if included_objects.blank?
included_objects = [included_objects] unless relationship_type == :has_many
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If belongs_to relation was empty there was the error undefined method `id' for nil:NilClass