-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cm] Non-realtime wrapper #72
Open
christhetree
wants to merge
6
commits into
main
Choose a base branch
from
cm--non_realtime_wrapper
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f46b266
to
36045dc
Compare
300d3ee
to
7f48808
Compare
70ef756
to
3609c96
Compare
f492bf5
to
fd5f3d6
Compare
a78fea0
to
c9554ab
Compare
e42ca44
to
7f8d2ac
Compare
a5e7f82
to
4edf97a
Compare
7f8d2ac
to
cb63c13
Compare
81762e0
to
77fdd21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defines a wrapper for non-realtime models making them compatible with the Neutone Gen plugin.
Most of the logic is in the constructor and the forward pass.
I wanted to allow the user to define NeutoneParameters in whatever order they like and all in one place rather than splitting up text and numerical parameters, which is why the constructor is a little bit more complicated than it would be otherwise.
One benefit is that we no longer need to worry about dynamic memory allocations which makes the code a bit cleaner in some cases.