Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] 알람 SnackBar #36

Merged
merged 8 commits into from
Feb 22, 2023
Merged

[FEATURE] 알람 SnackBar #36

merged 8 commits into from
Feb 22, 2023

Conversation

Mnseo
Copy link
Collaborator

@Mnseo Mnseo commented Feb 21, 2023

이슈 번호

#20

작업 내용

  • 앱 사용 시 알람 스낵바 UI (1.투표하러 가기 , 2.약속방 입장하기
    -1 완료, 2 진행중

ToDo

  • [ On-Going] 커스텀 스낵바 UI

참고사항

투표하러가기 스낵바 background로 깔았는데 잘 안보여서 🤔
layer transparent로 깔아야지 좀 명확하게 보일것 같아요 진행 후에 추가할게요!

@eshc123 eshc123 self-requested a review February 21, 2023 22:24
@eshc123 eshc123 assigned eshc123 and Mnseo and unassigned eshc123 Feb 21, 2023
@eshc123 eshc123 added feature New feature or request minseo labels Feb 21, 2023
eshc123
eshc123 reviewed Feb 21, 2023
View reviewed changes
Copy link
Member

@eshc123 eshc123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! 이번 스낵바 PR이랑 시스템 설정 PR이랑 별개의 작업이니 브랜치는 나눠서 작업해도 괜찮지 않았을까 생각합니다!

@Mnseo
Copy link
Collaborator Author

Mnseo commented Feb 21, 2023

헉 브랜치 따로 나눠서 작업된줄 알았습니다 하지만 커밋 로그가 그렇지 못하네요 ..🫠 죄송합니다 코멘트 감사해요

@Mnseo Mnseo merged commit 49761da into dev Feb 22, 2023
@eshc123 eshc123 deleted the feature/add-custom-snackbar branch February 28, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshc123 eshc123 eshc123 approved these changes

Assignees

@Mnseo Mnseo

Labels
feature New feature or request minseo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mnseo @eshc123