Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] FCM Notification #44

Merged
merged 8 commits into from
Feb 26, 2023
Merged

[FEATURE] FCM Notification #44

merged 8 commits into from
Feb 26, 2023

Conversation

eshc123
Copy link
Member

@eshc123 eshc123 commented Feb 26, 2023

이슈 번호

#40

작업 내용

  • Notification 작업
  • deeplink 연동

@eshc123 eshc123 added feature New feature or request seokjoon labels Feb 26, 2023
@eshc123 eshc123 requested a review from Mnseo February 26, 2023 01:56
@eshc123 eshc123 self-assigned this Feb 26, 2023
Comment on lines +39 to +42
createNotification(context = this,data)
Timber.d("asdasd ${data.contentType}")
} catch (e : Exception){
Timber.d("WwwException : onMessageReceived ")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이게 아까 방 참여했을때 로그 한건가요?,?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FCM을 통해서 푸시 알림 받았을 때 나오는 로그이긴한데 불필요한 로그는 안 쓰는게 좋으니까 나중에 한번 로그 정리 하도록 하겠습니다!

Copy link
Collaborator

@Mnseo Mnseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다 수고하셨어요 🙇🏻‍♀️💻

@eshc123 eshc123 merged commit d67439b into dev Feb 26, 2023
@eshc123 eshc123 deleted the feature/add-fcm-notification branch September 24, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request seokjoon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants