Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] 코드 리팩토링 - InfoViewModel #91

Merged
merged 5 commits into from
Mar 27, 2023
Merged

[REFACTOR] 코드 리팩토링 - InfoViewModel #91

merged 5 commits into from
Mar 27, 2023

Conversation

eshc123
Copy link
Member

@eshc123 eshc123 commented Mar 22, 2023 •
edited
Loading

이슈 번호

#89

작업 내용

  • InfoViewModel - Period 계산 부분 개선
  • InfoViewModel - InfoMessage 개선
  • InfoViewModel - checkCodeValid 개선

@eshc123 eshc123 requested a review from Mnseo March 22, 2023 23:07
@eshc123 eshc123 self-assigned this Mar 22, 2023
@eshc123 eshc123 temporarily deployed to Android CI/CD March 22, 2023 23:07 — with GitHub Actions Inactive
Mnseo
Mnseo approved these changes Mar 27, 2023
View reviewed changes
Copy link
Collaborator

@Mnseo Mnseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

대대적인 공사 수고하셨습니다 🙇‍♀️ 오늘 10시에 봐요!

@eshc123 eshc123 merged commit 5f29ef0 into dev Mar 27, 2023
@eshc123 eshc123 deleted the refactor/refac-info-viewmodel branch September 24, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mnseo Mnseo Mnseo approved these changes

Assignees

@eshc123 eshc123

Labels
refactor seokjoon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eshc123 @Mnseo