fix(cli): cache issue (codemod-com#1149)

NimishaDey · Jul 25, 2024 · ff179e9 · ff179e9
1 parent f8bd4ed
commit ff179e9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/apps/cli/src/fetch-codemod.ts b/apps/cli/src/fetch-codemod.ts
@@ -235,24 +235,19 @@ export const fetchCodemod = async (options: {
   const downloadPath = join(path, "codemod.tar.gz");
 
   const { data, cacheUsed } = await fileDownloadService
-    .download({
-      url: linkResponse.link,
-      path: downloadPath,
-      cachePingPath: join(path, ".codemodrc.json"),
-    })
+    .download({ url: linkResponse.link, path: downloadPath })
     .catch((err) => {
       spinner?.fail();
       throw new Error(
         (err as AxiosError<{ error: string }>).response?.data?.error ??
-          "Error downloading codemod from the registry",
+          (err as Error).message,
       );
     });
 
   // If cache was used, the codemod is already unpacked
   if (!cacheUsed) {
     try {
       await tarService.unpack(path, data);
-      await fs.unlink(downloadPath);
     } catch (err) {
       spinner?.fail();
       throw new Error((err as Error).message ?? "Error unpacking codemod");

diff --git a/apps/cli/src/file-download.ts b/apps/cli/src/file-download.ts
@@ -13,13 +13,12 @@ export class FileDownloadService {
   public async download(options: {
     url: string;
     path: string;
-    cachePingPath?: string;
   }): Promise<{ data: Buffer; cacheUsed: boolean }> {
-    const { url, path, cachePingPath = path } = options;
+    const { url, path } = options;
 
     if (this.cacheEnabled) {
       const localCodemodLastModified =
-        await this.__getLocalFileLastModified(cachePingPath);
+        await this.__getLocalFileLastModified(path);
       const remoteCodemodLastModified =
         await this.__getRemoteFileLastModified(url);