Only log silently caught exceptions to console in servers. (tModLoade…

…r#2647)
Nirke31 · Jun 29, 2022 · 2bcc2f3 · 2bcc2f3
1 parent c088eb0
commit 2bcc2f3
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/patches/tModLoader/Terraria/ModLoader/Logging.ExceptionHandling.cs b/patches/tModLoader/Terraria/ModLoader/Logging.ExceptionHandling.cs
@@ -104,23 +104,23 @@ private static void FirstChanceExceptionHandler(object sender, FirstChanceExcept
 						return;
 				}
 
+				tML.Warn(Language.GetTextValue("tModLoader.RuntimeErrorSilentlyCaughtException") + '\n' + exString);
+
 				previousException = args.Exception;
-				string msg = args.Exception.Message + " " + Language.GetTextValue("tModLoader.RuntimeErrorSeeLogsForFullTrace", Path.GetFileName(LogPath));
 
-				if (!Main.dedServ && ModCompile.activelyModding && !Main.gameMenu) {
-					AddChatMessage(msg);
-				}
-				else {
+				string msg = args.Exception.Message + " " + Language.GetTextValue("tModLoader.RuntimeErrorSeeLogsForFullTrace", Path.GetFileName(LogPath));
+				if (Main.dedServ) { // TODO, sometimes console write fails on unix clients. Hopefully it doesn't happen on servers? System.IO.IOException: Input/output error at System.ConsolePal.Write
 					Console.ForegroundColor = ConsoleColor.DarkMagenta;
 					Console.WriteLine(msg);
 					Console.ResetColor();
 				}
-
-				tML.Warn(Language.GetTextValue("tModLoader.RuntimeErrorSilentlyCaughtException") + '\n' + exString);
+				else if (ModCompile.activelyModding && !Main.gameMenu) {
+					AddChatMessage(msg);
+				}
 
 				if (oom) {
 					string error = Language.GetTextValue("tModLoader.OutOfMemory");
-					Logging.tML.Fatal(error);
+					tML.Fatal(error);
 					Interface.MessageBoxShow(error);
 					Environment.Exit(1);
 				}