Skip to content

Commit

Permalink
Revert spelling correction in licence matcher (flutter#7242)
Browse files Browse the repository at this point in the history
In f986a12 (flutter#7179), the word
'publically' was altered to 'publicly', causing the licence aggregator
to fail to match the licence text included in many BoringSSL source
files.

The original licence includes several misspellings (e.g. 'rouines'
rather than 'routines') which we need to faithfully reproduce in our
match regex.

The failure this triggered went unnoticed during pre-/post-submit
due to the fact that the contents of the third_party directory didn't
change, so hash of the list of files used as a signature matched the
signature in the golden file, causing the run to be skipped.
  • Loading branch information
cbracken authored Dec 18, 2018
1 parent f79f7f6 commit 5c63303
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/licenses/lib/patterns.dart
Original file line number Diff line number Diff line change
Expand Up @@ -1209,7 +1209,7 @@ final List<RegExp> csLicenses = <RegExp>[
r'^\1\2OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF *\n'
r'^\1\2SUCH DAMAGE\. *\n'
r'^(?:(?:\1\2?g? *)? *\n)*'
r'^\1\2The licence and distribution terms for any publicly available version or *\n'
r'^\1\2The licence and distribution terms for any publically available version or *\n'
r'^\1\2derivative of this code cannot be changed\. +i\.e\. +this code cannot simply be *\n'
r'^\1\2copied and put under another distribution licence *\n'
r'^\1\2\[including the GNU Public Licence\.\]',
Expand Down

0 comments on commit 5c63303

Please sign in to comment.