Skip to content

Commit

Permalink
perf-pipeline: Remove unnecessary jobs (dotnet#76111)
Browse files Browse the repository at this point in the history
* perf-pipeline: Set default value for ExtraSetupArguments

Fixes `line 1: ExtraSetupArguments: command not found` when running
performance/scripts/ci_setup.py .

* perf pipeline: Disable unncessary scheduled builds

`dotnet-runtime-perf` runs:
1. batched builds
2. scheduled builds at 2:30am every night

For the 'scheduled' case, only wasm/jsc perf jobs are run.
And the rest are build jobs - wasm, mono, coreclr, and libraries.

The wasm/jsc runs are known to be broken right now, thus they can be
disabled. And since there are no other perf jobs, none of the remaining
builds are needed, thus the whole scheduled run can be disabled.

* perf-pipeline: Collect logs file from perf runs on dotnet-runtime-perf also
  • Loading branch information
radical authored Sep 26, 2022
1 parent e445329 commit 19c5d17
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 7 deletions.
22 changes: 15 additions & 7 deletions eng/pipelines/coreclr/perf.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,18 +20,26 @@ trigger:
variables:
- template: /eng/pipelines/common/variables.yml

schedules:
- cron: "30 2 * * *"
displayName: Every night at 2:30AM
branches:
include:
- main
always: true
#
# For the 'schedule' case, only wasm/jsc perf jobs are run.
# And the rest are build jobs - wasm, mono, coreclr, and libraries.
#
# Since, we are not running *any* perf jobs, none of these builds are needed,
# thus the whole scheduled run can be disabled.
#
#schedules:
#- cron: "30 2 * * *"
#displayName: Every night at 2:30AM
#branches:
#include:
#- main
#always: true

jobs:

- template: /eng/pipelines/coreclr/perf-wasm-jobs.yml
parameters:
collectHelixLogsScript: ${{ variables._wasmCollectHelixLogsScript }}
${{ and(ne(variables['System.TeamProject'], 'public'), in(variables['Build.Reason'], 'Schedule')) }}:
runProfile: 'non-v8'
${{ if and(ne(variables['System.TeamProject'], 'public'), notin(variables['Build.Reason'], 'Schedule')) }}:
Expand Down
1 change: 1 addition & 0 deletions eng/pipelines/coreclr/templates/run-scenarios-job.yml
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ jobs:
- AdditionalHelixPreCommands: $(HelixPreCommandOSX)
- AdditionalHelixPostCommands: $(HelixPostCommandOSX)

- ExtraSetupArguments: ''
- name: ExtraSetupArguments
${{ if ne(parameters.runtimeType, 'wasm') }}:
value: --install-dir $(PayloadDirectory)/dotnet
Expand Down

0 comments on commit 19c5d17

Please sign in to comment.