Avoid allocations in 'Transfer-Encoding: Chunked' check (dotnet#81253)

Nisden · Jan 27, 2023 · d2eed6c · d2eed6c
1 parent f388963
commit d2eed6c
Showing 1 changed file with 13 additions and 2 deletions.
diff --git a/src/libraries/System.Net.Http/src/System/Net/Http/Headers/HttpGeneralHeaders.cs b/src/libraries/System.Net.Http/src/System/Net/Http/Headers/HttpGeneralHeaders.cs
@@ -81,14 +81,25 @@ public DateTimeOffset? Date
 
         internal static bool? GetTransferEncodingChunked(HttpHeaders parent, HttpGeneralHeaders? headers)
         {
-            if (parent.ContainsParsedValue(KnownHeaders.TransferEncoding.Descriptor, HeaderUtilities.TransferEncodingChunked))
+            if (parent.TryGetHeaderValue(KnownHeaders.TransferEncoding.Descriptor, out object? value))
             {
-                return true;
+                // Fast-path for the very common case where "chunked" is the only value.
+                if (value is string stringValue && stringValue.Equals("chunked", StringComparison.OrdinalIgnoreCase))
+                {
+                    return true;
+                }
+
+                if (parent.ContainsParsedValue(KnownHeaders.TransferEncoding.Descriptor, HeaderUtilities.TransferEncodingChunked))
+                {
+                    return true;
+                }
             }
+
             if (headers != null && headers._transferEncodingChunkedSet)
             {
                 return false;
             }
+
             return null;
         }