Remove redundant static ctor from LoggerFactory (dotnet#48478)

Nisden · Feb 19, 2021 · e6cc4ae · e6cc4ae
1 parent 040ffb5
commit e6cc4ae
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/src/libraries/Microsoft.Extensions.Logging/src/LoggerFactory.cs b/src/libraries/Microsoft.Extensions.Logging/src/LoggerFactory.cs
@@ -13,8 +13,6 @@ namespace Microsoft.Extensions.Logging
     /// </summary>
     public class LoggerFactory : ILoggerFactory
     {
-        private static readonly LoggerRuleSelector RuleSelector = new LoggerRuleSelector();
-
         private readonly Dictionary<string, Logger> _loggers = new Dictionary<string, Logger>(StringComparer.Ordinal);
         private readonly List<ProviderRegistration> _providerRegistrations = new List<ProviderRegistration>();
         private readonly object _sync = new object();
@@ -212,7 +210,7 @@ private LoggerInformation[] CreateLoggers(string categoryName)
 
             foreach (LoggerInformation loggerInformation in loggers)
             {
-                RuleSelector.Select(_filterOptions,
+                LoggerRuleSelector.Select(_filterOptions,
                     loggerInformation.ProviderType,
                     loggerInformation.Category,
                     out LogLevel? minLevel,

diff --git a/src/libraries/Microsoft.Extensions.Logging/src/LoggerRuleSelector.cs b/src/libraries/Microsoft.Extensions.Logging/src/LoggerRuleSelector.cs
@@ -5,9 +5,9 @@
 
 namespace Microsoft.Extensions.Logging
 {
-    internal class LoggerRuleSelector
+    internal static class LoggerRuleSelector
     {
-        public void Select(LoggerFilterOptions options, Type providerType, string category, out LogLevel? minLevel, out Func<string, string, LogLevel, bool> filter)
+        public static void Select(LoggerFilterOptions options, Type providerType, string category, out LogLevel? minLevel, out Func<string, string, LogLevel, bool> filter)
         {
             filter = null;
             minLevel = options.MinLevel;