-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document multi-user installation, and add release notes about it not being the default on 2.1 #2388
Conversation
your system, even if it is unsupported: | ||
|
||
<screen> | ||
curl https://nixos.org/nix/install | sh -s -- --daemon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't this give
No TTY, assuming you would say yes :)
regarding the y/n questions in the multi-user installer? That seems like a bad thing to recommend by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed by your recommendation on IRC, thank you!
3b635dc
to
368b305
Compare
</para> | ||
|
||
<para> | ||
I you would like to explicitly opt in or out of the multi-user Nix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
|
||
# If you are on macOS, you will need to run: | ||
sudo launchctl unload /Library/LaunchDaemons/org.nixos.nix-daemon.plist | ||
sudo launchctl unload /Library/LaunchDaemons/org.nixos.nix-daemon.plist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just once should be enough 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
installer: | ||
|
||
<screen> | ||
curl https://nixos.org/nix/install | sh -s -- --no-daemon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does passing flags to bash <(command)
not work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
41ac193
to
e4848fe
Compare
Rebased and squashed commits. |
sudo rm /Library/LaunchDaemons/org.nixos.nix-daemon.plist | ||
</screen> | ||
|
||
There may also be references to Nix in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't remember, are these steps skipped during install if references to /nix are found in these files? Or does it fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It fails.
43d277a
to
992e567
Compare
Running an install test suite. |
Install matrix says things are good (full report attached): note macos failed because I only built a tarball for linux. The changed part of the PR worked fine:
report-single-user-default.html.gz |
Use sh <(...) syntax for installation to preserve stdin and prompting also update installation docs to account for changes in multi-user selection
…t selected for Linux with systemd, and the bug about selinux
992e567
to
4be7652
Compare
doc/manual/release-notes/rl-2.1.xml
Outdated
<command>sudo -i sh -c 'nix-channel --update && nix-env -iA | ||
nixpkgs.nix'; sudo launchctl stop org.nixos.nix-daemon; sudo | ||
launchctl start org.nixos.nix-daemon</command>. | ||
</para> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the release notes are not the best place for platform-specific upgrade instructions, which are presumably the same for every release. Might be better to refer to some "Upgrading Nix" section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
Recommend adding a link to 4.4 to where a user can find the latest Nix binary tarball. |
What is the title of 4.4 you'd like a link to? |
Rendered docs:
Rendered release notes:
Ideally would be backported.