Skip to content

Commit

Permalink
lint fix
Browse files Browse the repository at this point in the history
  • Loading branch information
jhuleatt committed Jan 4, 2022
1 parent 3c103e4 commit 528596c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,14 @@ A full setup guide can be found [in the Firebase Hosting docs](https://firebase.
The [Firebase CLI](https://firebase.google.com/docs/cli) can get you set up quickly with a default configuration.

- If you've NOT set up Hosting, run this version of the command from the root of your local directory:

```bash
firebase init hosting
```

- If you've ALREADY set up Hosting, then you just need to set up the GitHub Action part of Hosting.
Run this version of the command from the root of your local directory:

```bash
firebase init hosting:github
```
Expand Down
8 changes: 4 additions & 4 deletions docs/service-account.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@ This action requires a service account to authenticate with Firebase Hosting. Th
1. Give the service account a name, id, description. We recommend something like `github-action-<my repository name>`
1. At the "Grant this service account access to project" step, choose the following [roles](https://firebase.google.com/docs/projects/iam/roles-predefined-product) that the service account will need to deploy on your behalf:
- **Firebase Authentication Admin** (Required to add preview URLs to Auth authorized domains)
+ `roles/firebaseauth.admin`
- `roles/firebaseauth.admin`
- **Firebase Hosting Admin** (Required to deploy preview channels)
+ `roles/firebasehosting.admin`
- `roles/firebasehosting.admin`
- **Cloud Run Viewer** (Required for projects that [use Hosting rewrites to Cloud Run or Cloud Functions](https://firebase.google.com/docs/hosting/serverless-overview))
+ `roles/run.viewer`
- `roles/run.viewer`
- **API Keys Viewer** (Required for CLI deploys)
+ `roles/serviceusage.apiKeysViewer`
- `roles/serviceusage.apiKeysViewer`
1. Finish the service account creation flow

### 2. Get that service account's key and add it to your repository as a secret
Expand Down

0 comments on commit 528596c

Please sign in to comment.