Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for ActionMailer deliver_later #675

Closed
richardardrichard opened this issue Feb 18, 2015 · 7 comments
Closed

Add Support for ActionMailer deliver_later #675

richardardrichard opened this issue Feb 18, 2015 · 7 comments

Comments

@richardardrichard
Copy link

Could the generic_send_email method be updated to allow for configurable use of the new deliver_later functionality in Rails (http://edgeguides.rubyonrails.org/active_job_basics.html#action-mailer)?

I would be willing to open a PR for this 😄.

@arnvald
Copy link
Collaborator

arnvald commented Feb 19, 2015

Hi @richardardrichard,

that'a good idea! I think about adding email_delivery_method option to config. This would default to deliver for Rails < 4.2 and to deliver_now for 4.2+, and it could be changed to deliver_later in config file. What do you think about it?

@richardardrichard
Copy link
Author

Sounds good, I'll get started!

@LimeBlast
Copy link

Sorry, nothing productive here, I just wanted to add a 👍

@dpereira411
Copy link

Was this done?

@richardardrichard
Copy link
Author

Nope, I ran out of time, feel free to take it!

@wendy0402
Copy link
Contributor

Hi, I try to make it here. Here is the pull request, #696

@wendy0402
Copy link
Contributor

I guess this issue can be closed now

@arnvald arnvald closed this as completed Jun 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants