add feature to deliver later

[wendy0402]

It is feature to use deliver_later method that exists since rails 4.2 for Action Mailer by using active job( the issue is raised here: #675).

If the test is not good enough please tell me, thanks

[arnvald]

Hi @wendy0402,

thanks a lot for your work!
I'm wondering if instead of using respond_to a few times, wouldn't it be better to just let user specify method responsible for sending emails? i.e.
user.email_delivery_method = :deliver_now

This could default to :deliver_now for rails 4.2+ and :deliver for older versions.

It has 2 advantages over current approach:

• config name is more accurate (deliver_later_enabled does not fully explain that it's about email, and the word "enabled" does not really mean that it will be used.)
• the code responsible for sending email is simpler - we just need to run mail.send(config.email_delivery_method) and not care if mailer responds to certain method or not

What's your opinion?

[wendy0402]

Hi @arnvald ,
so do you mean they are the one who choose to use deliver_now, deliver, or deliver_later? that can be a good idea, just need to add more information in initializer about the condition, I will update it, thanks for the suggestion

[wendy0402]

I just remember, how about other user that after update the gem, they need to update their initializer also. we should make default method for them right? if true, do you think it is nice to check based on the rails version?

[arnvald]

@wendy0402

yes, so the documentation for user in initializer should specify that 3 methods are available: deliver, deliver_now and deliver_later.
By default deliver or deliver_now should be set based on rails version - user shouldn't be forced to updating initializer, update should be only if they want to set deliver_later

[wendy0402]

If you think there is better solutions for how to check rails version, please tell me, I'll update it, thanks!

[arnvald]

Yes, there's an easier approach. You can use Gem::Version class:

if Gem::Version.new("4.2.0") <= Gem::Version.new(Rails.version)
  :deliver_now
else
  :deliver
end

[arnvald]

You can just use mail.send(config.email_delivery_method) here

[arnvald]

@wendy0402 sorry for late reply. I've just checked the code again, there's just one small fix and PR is ready to merge 👍

[wendy0402]

no problem @arnvald , I guess it is ready now

[arnvald]

Merged, thank you for your work!